Add multi-line input support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is cool, however might break quite a few downstream libraries that use |
|
This should be fine, it just adds another argument to runRepl. Just need to merge the multi-line logic with the finaliser logic and then it should be good. |
|
Great! :) I'll rebase it on the latest |
|
I meant |
The way this multi-line input works is very much inspired by the PureScript REPL which also uses `haskeline`: purescript/purescript#934 (comment) The name of the command is configurable, so it could be called `m`, `paste`, `multiline`, or whatever works best for the application using this. The banner can now take into account if it's in the middle of a multi-line input or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way this multi-line input works is very much inspired by the PureScript REPL which also uses
haskeline:purescript/purescript#934 (comment)
The name of the command is configurable, so it could be called
m,paste,multiline, or whatever works best for the application using this.The banner can now take into account if it's in the middle of a multi-line input or not.
This PR might make #25 redundant.