-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Liquibase Candidate #683
Conversation
…igration001 method to insert Liquibase candidate into the database
Hi @jandroav! Because the respective |
Thanks @helpermethod ! Is there anything else we need to do to have |
…r consistency refactor(LiquibaseMigrations.scala): update Liquibase description for clarity and conciseness
Hi @jandroav 👋 |
Formatting failure @jandroav. Please see the README on how to run scalafmt. |
…lity and consistency in indentation and spacing
Formatting fixed and API creds requested. Thanks for your quick review on this @marc0der ! |
Hi @jandroav, it looks like your code doesn't compile. You might need to look at some of the other migrations to see how it's done. You should probably use IntelliJ or VSCode with Metals. If not, at least use SBT to build and verify that it's correct. All instructions are in the README. |
…claration for consistency feat(LiquibaseMigrations.scala): add Liquibase migration change log for version 1.2.3 by jandroav
…move version number for consistency and clarity
Hi @marc0der, sorry, imports were missing. Now it builds. |
Hey @marc0der I see one build issue but I am not sure if it is related to my changelog: https://github.com/sdkman/sdkman-db-migrations/actions/runs/8060565235/job/22024825534 |
Hi @jandroav! The error is unrelated to your PR. |
Thanks @helpermethod ! How long does it usually take to have the PR merged and ready to upload versions to I also sent an email from my |
hi @helpermethod @marc0der 😄 . Anything we can do to help get this moved forward? Thanks so much for your help! |
@jnewton03 @jandroav The problem was due to a dodgy migration, which I've now removed. I also rebased your PR against the updated master and merged it. GitHub doesn't always pick rebases so I'll close this PR now that it is merged. |
Thanks @marc0der ! We sent the last feb 26 a mail with our public key as shown here https://github.com/sdkman/sdkman-cli/wiki/Vendor-onboarding-process but we did not get a reply. Is there anything else we need to do to be able to send liquibase versions? |
No probs, I'll look into it shortly. |
Hi there, just a quick follow-up to remind you that we're eagerly awaiting approval of our public key to start using |
Hello team, we have a question about https://github.com/sdkman/sdkman-cli/wiki/Well-formed-SDK-archives.
We are already generating a
zip
file forliquibase
. It almost complies with the Well-formed-SDK-archives guide except for the bin folder. We are shipping the executable in the root folder:We are ok if we need to generate a different
zip
file forSDKMAM
like the following:But we would like to know if we could create a
bin
directory and symlink the required files into it (or move tobin and symlink to root dir). This involves the creation of a
tar. which supports symbolic links instead of azip
file.