feat: Add jextract candidate #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
helpermethod
commented
May 30, 2024
marc0der
reviewed
May 30, 2024
|
Hi @marc0der! We still need to make some changes to the sdkman-hooks project, right? Or are they still in place? |
helpermethod
force-pushed
the
feat/add-jextract-candidate
branch
from
6d7f36c
to
ab0e24b
Compare
|
Squashed all commits for a cleaner history. |
|
I also gave it a go on my machine and it actually creates a Java binding for a corresponding C header. 
|
|
@marc0der Can we merge this please? I need to get this out of my head 😆. |
|
Sorry, just saw this now! Happy for you to merge it @helpermethod . |
marc0der
approved these changes
Aug 4, 2024
|
@marc0der For some reason the candidate doesn't show up. Any idea why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marc0der @aalmiray
The jextract guys finally moved the binary to bin and make use of an embedded JDK which resides in a different folder.