Test performance #302
Closed
Test performance #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to run the selective version, but ran into an error where I did not have the |
|
Replaced by #307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<<Added new features to the test_performance script, bug fixes>>
Summary:
Added new functionality, can run either the iterative version (starting from 2 NFs to a specified # of max NFs) or the selective
version. Added type checking at the beginning of the script so that it ensures the proper inputs are given. Recreated graph so that it looks cleaner. Made a copy of the data that can be viewed at the end of running.
Usage:
Merging notes:
TODO before merging :
Test Plan:
Run by other people
Review:
(optional) << @-mention people who should review these changes >>
(optional) Subscribers: << @-mention people who probably care about these changes >>