Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prints out socket that is in use whenever core is also printed out. Also outputs socket ID to CSV. #308

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

NoahChinitz
Copy link
Contributor

Summary:

This PR changes two files, main.c in onvm_mgr and onvm_nflib.c in onvm_nflib. All printf statements that had core information in them were added to include the socket information as well. It also adds the information to the CVS files that output at the end of execution.
Usage:
There is nothing that needs to be done to have this work other than make clean && make in onvm and examples.

This PR includes
Resolves issues
Breaking API changes
Internal API changes
Usability improvements x
Bug fixes
New functionality
New NF/onvm_mgr args
Changes to starting NFs
Dependency updates
Web stats updates

Merging notes:

  • Dependencies: None

TODO before merging :

  • PR is ready for review

Test Plan:

Tested by running the manager and various NFs to make sure the socket information was output correctly.

Review:

@twood02
@dennisafa

Copy link
Member

@twood02 twood02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems straight forward, but since I haven't compiled/run it, can you show us a screenshot of the working output?

@NoahChinitz
Copy link
Contributor Author

@twood02
Manager Start Up:
mgr_start
Manager Exit:
mgr_end
NF Start Up:
nf_start
NF Exit:
nf_end
NF CSV:
nf_csv

@twood02
Copy link
Member

twood02 commented Sep 1, 2021

looks good. I think it's ready to go.

@twood02 twood02 added the ready-for-gatekeeper 🚪 PRs that have been approved and are ready for a final review/merge label Sep 1, 2021
@dennisafa dennisafa merged commit d6483ed into sdnfv:develop Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-gatekeeper 🚪 PRs that have been approved and are ready for a final review/merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants