ci: add main database check action #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
automation
branch
2 times, most recently
from
b427b90
to
3e03808
Compare
This commit adds the `check_main_databases` github action that is used to check whether the main databases are correctly formatted. This action checked whether: - The databases don't contain duplicate ICAOs. - The databases don't contain duplicate registration numbers. - The databases don't contain incorrect urls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pull request adds the main_databases_check.yml action. This action runs when any of the main database files (i.e. plane-alert-db.csv, plane-alert-twitter-blocked.csv, plane-alert-pia.csv, plane-alert-ukraine.csv and plane_images.txt) is changed and checks:
It looks like the plane-alert-db.csv already contains duplicate registration numbers (see #103) so I temporarily disabled this check:
plane-alert-db/scripts/check_main_databases.py
Line 90 in 3e03808
Checklist before requesting a review