Add a GIO version of accept_async #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the server-side functions just like we have them e.g. for tokio so we can run servers.
Not doing so means we rudely disconnect from the socket without clong out our websocket stream
This lets us use the SocketService we might already want to use and use it for a websocket server.
sdroege
reviewed
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like we have
accept_asyncfor tokio and async_std, we can build one for GIO so we can use something likegio::SocketServiceto handle the accepting and then we can spawn off tasks.This comes also with a sample server just to make sure it can work.