Skip to content

Commit

Permalink
Make processConfigs function pure virtual (facebookincubator#10827)
Browse files Browse the repository at this point in the history
Summary:
to enforce every data format implement its own processConfigs functions

Pull Request resolved: facebookincubator#10827

Reviewed By: xiaoxmeng

Differential Revision: D61743118

Pulled By: kewang1024

fbshipit-source-id: aa1d0b2ea12deaf5b2c2f2ee16827bd6c5a73f38
  • Loading branch information
kewang1024 authored and facebook-github-bot committed Aug 24, 2024
1 parent 8d45b3c commit 3d10ccf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion velox/dwio/common/Options.h
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ struct WriterOptions {
// process format-specific session and connector configs.
virtual void processConfigs(
const config::ConfigBase& connectorConfig,
const config::ConfigBase& session) {};
const config::ConfigBase& session) = 0;

virtual ~WriterOptions() = default;
};
Expand Down

0 comments on commit 3d10ccf

Please sign in to comment.