Update README to show that we run Appraisal on haml 5/6 not 4/5 #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**WHAT** Update README to show that we run Appraisal on haml 5/6 not 4/5 **WHY** Haml 4 compatibility was dropped in [this pr](sds#466) as it was in `Appraisals`. There was not a corresponding update in the README to reflect this change and it still reads `we use Appraisal to test against both HAML 4 and 5` which is now out of date.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Update README to show that we run Appraisal on haml 5/6 not 4/5
WHY
Haml 4 compatibility was dropped in this pr as it was in
Appraisals. There was not a corresponding update in the README to reflect this change and it still readswe use Appraisal to test against both HAML 4 and 5which is now out of date.