Add xread block and count support #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deleted the
ghost
commented
Jul 2, 2020
| @@ -47,4 +47,20 @@ | |||
| expect(@redises.xread([@key, @key1], %w[1234567891234-2 1234567891234-1])) | |||
| .to eq({ @key1 => [['1234567891234-2', { 'key1' => 'value2' }]] }) | |||
| end | |||
|
|
|||
| it 'supports the block parameter' do | |||
There was a problem hiding this comment.
@sds I accepted the block parameter but don't do anything with it. Do you implement blocking anywhere else in the mock_redis? I had considered just doing a sleep block/1000.0 but didn't see sleep anywhere else in the code base. Of course only doing the sleep if the result was empty.
There was a problem hiding this comment.
We will rely on users of this library to report any issues with what you've implemented, and provide a PR fixing the logic to add the support if it is needed. Thank you!
|
@sds could you create a new release which incorporates this change? |
|
0.26.0 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.