New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing conditional type coercion for zset.add #214

Merged

sds merged 1 commit into sds:master from vincentamoore:removing-conditional-type-coercion-for-zset-add

Jul 22, 2021

Contributor

vincentamoore commented Jul 20, 2021 •

edited

Loading

Redis represents zset scores as floats internally, but mock_redis attempts to coerce zset scores to integers. This coercion prevents certain float values from being used as scores (eg. Float::INFINITY).

This PR removes the conditional type coercion from the zset add method, and instead converts all scores to floats.


          Removing conditional type coercion for zset.add

1da131e

sds added the bug label

sds merged commit fc03a07 into sds:master

Owner

sds commented Jul 22, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug