Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type streamy #275

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Type streamy #275

merged 4 commits into from
Sep 5, 2023

Conversation

jmthomas
Copy link
Contributor

I think the recent change to scan that added the call to type is breaking me because I'm using streams. I'm getting the following stack trace:

    ArgumentError:
       Not sure how #<MockRedis::Stream:0x00007fcceb5db3e8 @members=#<Set: {[#<MockRedis::Stream::Id:0x00007fcceb5db2d0 @exclusive=false, @sequence=0, @timestamp=1691767286667>, {"kind"=>"created", "type"=>"group", "data"=>"{\"name\":\"DEFAULT\",\"scope\":\"TEST\",\"updated_at\":1691767286666973366}"}], [#<MockRedis::Stream::Id:0x00007fcceb5e3278 @exclusive=false, @sequence=1, @timestamp=1691767286667>, {"kind"=>"deployed", "type"=>"group", "data"=>"{\"name\":\"DEFAULT\",\"scope\":\"TEST\",\"updated_at\":1691767286666973366}"}]}>, @last_id=#<MockRedis::Stream::Id:0x00007fcceb5e3278 @exclusive=false, @sequence=1, @timestamp=1691767286667>> got in here
     # ./vendor/bundle/ruby/3.1.0/gems/mock_redis-0.37.0/lib/mock_redis/database.rb:271:in `type'
     # ./vendor/bundle/ruby/3.1.0/gems/mock_redis-0.37.0/lib/mock_redis/utility_methods.rb:40:in `block in common_scan'
     # ./vendor/bundle/ruby/3.1.0/gems/mock_redis-0.37.0/lib/mock_redis/utility_methods.rb:38:in `select'
     # ./vendor/bundle/ruby/3.1.0/gems/mock_redis-0.37.0/lib/mock_redis/utility_methods.rb:38:in `common_scan'
     # ./vendor/bundle/ruby/3.1.0/gems/mock_redis-0.37.0/lib/mock_redis/database.rb:155:in `scan'
     # ./vendor/bundle/ruby/3.1.0/gems/mock_redis-0.37.0/lib/mock_redis/database.rb:162:in `block in scan_each'
     # ./vendor/bundle/ruby/3.1.0/gems/mock_redis-0.37.0/lib/mock_redis/database.rb:161:in `loop'
     # ./vendor/bundle/ruby/3.1.0/gems/mock_redis-0.37.0/lib/mock_redis/database.rb:161:in `scan_each'

I think this addition to add streamy to type will fix it. Not sure where in the tests this should go ...

@sds sds added the bug label Sep 5, 2023
@sds sds merged commit f4a151d into sds:main Sep 5, 2023
6 checks passed
@sds
Copy link
Owner

sds commented Sep 5, 2023

Thanks!

@jmthomas jmthomas deleted the type_streamy branch September 5, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants