feat: Add a PR template

[gabyx]

Contents

Playing around with some Best-Practices.
Comments welcome.

@supermaxiste, @cmdoret : Can we push this repo into a working mode where we try to apply as many Best Practices as possible.
We are already doing nice, PRs have all a convention commit title.
Commits are conventional commits. When we merge, the commits on the branch should follow conv. commit message format, otherwise squash merge and make one proper description (I always do that).
So we can just take this repository as a test piece with the team to see how far can we push it.
So CI will come. I would like to add one either on Github
(prefer Gitlab because Github CI is akward with their actions setup, even unsecure too... I can give it a try, might be good too to not have predjustice, but among DevOps Github it does not have a good reputation)

[cmdoret]

Cool, yeah the PR template looks good to me; short and to the point. I like the idea of having a checklist in there :)

[cmdoret]

I think we gotta stay on Github (at least for now), but for actions related to conventional commits, @supermaxiste already set something up in other repos, we could maybe reuse it here :)

[gabyx]

I mean, Gitlab can run CI and report to Github, cant it? I mean we just need to push to both urls. Ok the branch do not get deleted when PRs close etc... but jeah...

Github Actions why they are bad: https://www.youtube.com/watch?v=9qljpi5jiMQ
This is a really really profound review why they are really not so ideal. also the author is actually a really good rust streamer lol

[cmdoret]

Thanks for the link @gabyx, I understand what you mean now.
I am personally not against connecting a gitlab CI/CD project to this repo, we can discuss it with the team.