Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes error propagation #200

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Fixes error propagation #200

merged 5 commits into from
Feb 5, 2025
+188 −69

Conversation

ajmejia
Copy link
Contributor

@ajmejia ajmejia commented Feb 3, 2025 •
edited
Loading

This PR fixes a couple error propagation issues and adds QA plots to keep track of error propagation in several data reduction stages.

Main changes are:

  • Removes faulty error propagation in CR rejection
  • Removes density conversion of inverse variance in flux conserving resampling
  • Adds QA plots to check error propagation in detrending, extraction, wavelength rectification

@ajmejia ajmejia marked this pull request as ready for review February 5, 2025 17:12
@ajmejia ajmejia merged commit 825c120 into master Feb 5, 2025
8 checks passed
@ajmejia ajmejia deleted the fixerrprop branch February 5, 2025 17:14
@ajmejia ajmejia mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ajmejia