Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long-term calibration sequence #87

Merged
merged 44 commits into from
May 16, 2024
Merged

Long-term calibration sequence #87

merged 44 commits into from
May 16, 2024

Conversation

ajmejia
Copy link
Contributor

@ajmejia ajmejia commented May 16, 2024

Implements a script to reduce long-term calibration sequence and produce calibration frames:

  • bias: lvm-mbias-*.fits
  • fiber trace: lvm-mtrace-*.fits and lvm-mwidth-*.fits
  • wavelength: lvm-mwave-*.fits and lvm-mlsf-*.fits
  • fiberflat: lvm-mfiberflat_twilight-*.fits

Main changes are:

  • Implementing handling of QC reports on pixel shifts
  • Implementing CLI for long-term calibrations script
  • Bug fixes all across calibration routines (e.g., fiber tracing, wavelength, fiberflats, flux calibration)
  • Implementing stray light subtraction for science reductions
  • Improving handling of incomplete calibration sequences

ajmejia added 30 commits May 3, 2024 20:57
@ajmejia
implementing long-term calibration routine
b23f5fd
@ajmejia
quick fix to frames metadata
2700262
@ajmejia
implementing QC shift reports & interactive mode to choose solve disc…
fd337d5 
…repancies
@ajmejia
implementing guess of reference frame
c3a5e2c
@ajmejia
handling annoying extra lines
82c1b6b
@ajmejia
cleaning print
714af30
@ajmejia
better handling of conflicting shifts (fixes Implement Dmitry's pixel…
3af6c5d 
… shifts reports #85)
@ajmejia
refining selection of reference & fixing bugs
0632954
@ajmejia
fixing finding of reference image
218fd72
@ajmejia
Merge branch 'master' into ltcals
be55bbd
@ajmejia
implementing CLI for long-term calibrations
6f31173
@ajmejia
fixing bug on missing references
ba68c7b
@ajmejia
fixing hard-coded parameters in tracing
8520528
@ajmejia
improved handling of invalid errors & fixed writting of output traces
cc638c2
@ajmejia
returning tck tuple
576cc57
@ajmejia
fixing sequence selection
b19daaf
@ajmejia
fixing moving of long-term cals to sandbox
0ffac12
@ajmejia
fixing sequences order
1271ce7
@ajmejia
fixing hard-coded values in fiber thermal shifts, improved stats & log
90414d9
@ajmejia
improving stray light subtraction for science frames
af7dd3b
@ajmejia
implementing stray light subtraction for science reductions
7dc4643
@ajmejia
fixing handling of new paths in fiducial calibrations
b14dfe9
@ajmejia
fixing minor bug
661f465
@ajmejia
fixing bug in straylight subtraction
180c784
@ajmejia
fixing fit_continuum output
6451f51
@ajmejia
making stray light subtraction consistent all across
3942eec
@ajmejia
removing replacement of masked values in stray light subtraction
fc25177
@ajmejia
adding missing path
1dbd830
@ajmejia
improving error propagation and masked pixels handling in extraction
bb9e4b8
@ajmejia
improving spline fitting for stray light modeling & fixing mask propa…
a0ae36f 
…gation
@ajmejia ajmejia added bug Something isn't working enhancement New feature or request labels May 16, 2024
@ajmejia ajmejia self-assigned this May 16, 2024
@ajmejia ajmejia merged commit e507f1e into master May 16, 2024
8 checks passed
@ajmejia ajmejia deleted the ltcals branch May 16, 2024 17:43
This was referenced May 16, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ajmejia ajmejia

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ajmejia