Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update boss paths for v6_2+ #65

Merged
merged 14 commits into from
Nov 7, 2024
Merged

update boss paths for v6_2+ #65

merged 14 commits into from
Nov 7, 2024

Conversation

Sean-Morrison
Copy link
Contributor

Made modifications with the addition of new special functions to support the v6_2_0+ BOSS DRP paths while maintaining backward compatibility for older pipeline reductions

@Sean-Morrison Sean-Morrison self-assigned this Nov 1, 2024
@Sean-Morrison
Copy link
Contributor Author

The changes here are to support sdss/tree#94, so the tests are failing since the new path templates are not available to the tests

Copy link
Collaborator

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some tests failing in the CI, but this could be due to the waiting PR on tree. Will wait to see if that fixes them before approving.

python/sdss_access/path/path.py Outdated Show resolved Hide resolved
python/sdss_access/path/path.py Outdated Show resolved Hide resolved
python/sdss_access/path/path.py Outdated Show resolved Hide resolved
python/sdss_access/path/path.py Outdated Show resolved Hide resolved
python/sdss_access/path/path.py Outdated Show resolved Hide resolved
python/sdss_access/path/path.py Outdated Show resolved Hide resolved
python/sdss_access/path/path.py Outdated Show resolved Hide resolved
python/sdss_access/path/path.py Outdated Show resolved Hide resolved
python/sdss_access/path/path.py Outdated Show resolved Hide resolved
@havok2063
Copy link
Collaborator

@Sean-Morrison I merged in the tree PR. The CI for this PR is failing with some linting issues. Looks like a syntax error. Can you check that?

Copy link
Collaborator

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good now. Thanks @Sean-Morrison

@havok2063 havok2063 merged commit 7896f78 into main Nov 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants