Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HAR write utils #175

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add HAR write utils #175

merged 1 commit into from
Nov 13, 2024

Conversation

uarlouski
Copy link
Contributor

No description provided.

@uarlouski uarlouski changed the title Add ability to write har as bytes Add HAR write utils Nov 13, 2024
@uarlouski uarlouski marked this pull request as ready for review November 13, 2024 13:28
@uarlouski
Copy link
Contributor Author

Hi @sdstoehr :) can you please take a look?

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (9ba503e) to head (0a24502).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/de/sstoehr/harreader/HarWriter.java 80.95% 4 Missing ⚠️
.../java/de/sstoehr/harreader/HarWriterException.java 0.00% 2 Missing ⚠️
src/main/java/de/sstoehr/harreader/HarReader.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #175       +/-   ##
=============================================
+ Coverage     66.18%   78.54%   +12.36%     
- Complexity      297      388       +91     
=============================================
  Files            24       27        +3     
  Lines           686      713       +27     
  Branches        130      130               
=============================================
+ Hits            454      560      +106     
+ Misses          207      153       -54     
+ Partials         25        0       -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdstoehr sdstoehr merged commit 2c27095 into sdstoehr:main Nov 13, 2024
5 checks passed
@sdstoehr
Copy link
Owner

@uarlouski Thanks for your contribution.

This is included in version 2.4.0 - might take a while until it is available through Maven Central.

@uarlouski
Copy link
Contributor Author

@sdstoehr thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants