Remove bumpversion and use bump-my-version #90
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 78.98% 79.12% +0.13%
==========================================
Files 7 7
Lines 728 728
==========================================
+ Hits 575 576 +1
+ Misses 153 152 -1 ☔ View full report in Codecov by Sentry. |
pyproject.toml
Outdated
| [tool.setuptools.package-data] | ||
| "*" = [ | ||
| '*.txt', | ||
| '*.md', | ||
| '*.rst', | ||
| 'README.md', | ||
| 'docs/*', | ||
| 'Makefile', | ||
| 'make.bat', | ||
| '*.jpg', | ||
| '*.png', | ||
| '*.gif', | ||
| ] |
There was a problem hiding this comment.
why are we adding this now?
There was a problem hiding this comment.
- This specifies, what should be included in the whl/tar.gz file (when making the package). We should keep this as minimal as possible (to avoid making our released package too large).
- One thought is we should not include the
docsfolder.
There was a problem hiding this comment.
Do we need the *.txt? It seems like our MANIFEST doesn't include it anyway
There was a problem hiding this comment.
With pyproject.toml, you can actually remove MANIFEST.in file.
All files specified by the package-data and data-files configuration parameters in pyproject.toml and/or equivalent in setup.cfg/setup.py;
https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html
There was a problem hiding this comment.
@R-Palazzo will approve once MANIFEST.in is removed.
|
@R-Palazzo regarding the version folder. Yes that is fine. |
pyproject.toml
Outdated
| @@ -15,7 +15,7 @@ classifiers = [ | |||
| 'Topic :: Scientific/Engineering :: Artificial Intelligence', | |||
| ] | |||
| keywords = ['deepecho', 'DeepEcho'] | |||
| dynamic = ["version"] | |||
| version = '0.5.1.dev0' | |||
There was a problem hiding this comment.
Let's follow what we did with Copulas:
There was a problem hiding this comment.
Yes I was not sure, I checked with @amontanez24. Done in b1fa699
CU-86azg1dg3
Resolve #87
@amontanez24 @gsheni SDV has a version folder while our other libraries define their
__version__inside their__init__.pydirectly, is it fine?