Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove input error from base synthesizer class once nullable foreign keys are supported #2057

Closed
gsheni opened this issue Jun 12, 2024 · 0 comments
Closed

Remove input error from base synthesizer class once nullable foreign keys are supported #2057

gsheni opened this issue Jun 12, 2024 · 0 comments
Assignees
@rwedge
Labels
feature request Request for a new feature
Milestone
1.16.0

Comments

@gsheni
Copy link
Contributor

gsheni commented Jun 12, 2024 •
edited
Loading

Problem Description

  • Currently, a SynthesizerInputError is raised if the data contains null foreign keys.
  • We would like to remove this error once our synthesizers support null foreign keys.

Expected behavior

  • Remove this check, which raises a SynthesizerInputError

    SDV/sdv/multi_table/base.py

    Line 449 in 1286211

    _validate_foreign_keys_not_null(self.metadata, data)
  • Update any associated tests (possibly remove them).
@gsheni gsheni added feature request Request for a new feature new Automatic label applied to new issues and removed new Automatic label applied to new issues labels Jun 12, 2024
@rwedge rwedge mentioned this issue Jun 18, 2024
Merged
@rwedge rwedge self-assigned this Jun 20, 2024
@rwedge rwedge added this to the 1.16.0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwedge rwedge

Labels
feature request Request for a new feature
Projects
None yet
Milestone
1.16.0
Development

No branches or pull requests
3 participants
@rwedge @amontanez24 @gsheni