Remove input error on null foreign keys from BaseMultiTableSynthesizer.fit #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwedge
requested review from
frances-h and
gsheni
and removed request for
a team
rwedge
commented
Jun 18, 2024
| ) | ||
| with pytest.raises(SynthesizerInputError, match=err_msg): | ||
| synthesizer.fit(data) | ||
| synthesizer.fit(data) |
There was a problem hiding this comment.
When HMA is updated to support null foreign keys we should add more assertions here
frances-h
approved these changes
Jun 18, 2024
gsheni
approved these changes
Jun 20, 2024
rwedge
added a commit
that referenced
this pull request
Jul 12, 2024
rwedge
added a commit
that referenced
this pull request
Aug 16, 2024
rwedge
added a commit
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2057