Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metadata visualization #153

Merged
merged 7 commits into from
Feb 2, 2020

Conversation

JDTheRipperPC
Copy link
Contributor

Resolves #151

  • Added background color
  • Added spacing to the arrow labels
  • Added box with extra information below the fields
  • Changed arrow style to "crow"

@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #153 into master will increase coverage by 2.89%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   87.96%   90.85%   +2.89%     
==========================================
  Files          12       12              
  Lines         864      886      +22     
==========================================
+ Hits          760      805      +45     
+ Misses        104       81      -23
Impacted Files Coverage Δ
sdv/metadata.py 89.56% <94.44%> (+7.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ab1ead...88294aa. Read the comment docs.

@csala csala merged commit 80c948b into master Feb 2, 2020
@csala csala deleted the issue_151_improve_metadata_visualization branch February 2, 2020 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve metadata visualization
3 participants