Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usage logging #1920

Merged
merged 19 commits into from
Apr 25, 2024
Merged

Add usage logging #1920

merged 19 commits into from
Apr 25, 2024

Conversation

pvk-developer
Copy link
Member

Resolves #1903
CU-86b00n5d2

@sdv-team
Copy link
Contributor

Task linked: CU-86b00n5d2 SDV - Add usage logging #1903

@pvk-developer pvk-developer marked this pull request as ready for review April 19, 2024 17:17
@pvk-developer pvk-developer requested a review from a team as a code owner April 19, 2024 17:17
@pvk-developer pvk-developer requested review from frances-h and amontanez24 and removed request for a team April 19, 2024 17:17
amontanez24
amontanez24 reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! The one thing I think we need still is the ability to completely disable the loggers from the config

pyproject.toml Outdated Show resolved Hide resolved
sdv/logging/utils.py Outdated Show resolved Hide resolved
sdv/multi_table/base.py Show resolved Hide resolved
sdv/logging/utils.py Outdated Show resolved Hide resolved
frances-h
frances-h reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add an integration test as well? Maybe just checking that the file exists and that logs from the run are present at the end of the file?

amontanez24
amontanez24 reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! A couple small comments

pyproject.toml Show resolved Hide resolved
sdv/single_table/base.py Outdated Show resolved Hide resolved
amontanez24
amontanez24 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pvk-developer pvk-developer merged commit 275955d into main Apr 25, 2024
46 checks passed
@pvk-developer pvk-developer deleted the issue-1903-add-usage-logging branch April 25, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frances-h frances-h frances-h approved these changes

@lajohn4747 lajohn4747 lajohn4747 approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add usage logging
5 participants
@pvk-developer @sdv-team @amontanez24 @lajohn4747 @frances-h