Do not enforce min/max on sequence index column #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frances-h
reviewed
Jun 3, 2024
sdv/sequential/par.py
Outdated
Comment on lines
220
to
221
| if sequence_index_transformer.enforce_min_max_values: | ||
| sequence_index_transformer.enforce_min_max_values = False |
There was a problem hiding this comment.
If a user updated the sequence index transformer and set enforce_min_max_values to True, would this ignore that? It might be better to only change the transformer when it's been automatically assigned, so that way if a user modifies it we don't overwrite their change.
There was a problem hiding this comment.
Sounds good! I moved it into a overridden auto_assign_method so it's always after being auto assigned.
amontanez24
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2031
CU-86b0me61g
Do not enforce min/max on sequence index column so it does not cause duplication of the seq_index