Always create a sample size of 1 no matter how small the scale. #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frances-h
approved these changes
Jun 13, 2024
sdv/sampling/hierarchical_sampler.py
Outdated
| synthesizer = self._table_synthesizers[table] | ||
| LOGGER.info(f'Sampling {num_rows} rows from table {table}') | ||
| sampled_data[table] = self._sample_rows(synthesizer, num_rows) | ||
| self._sample_children(table_name=table, sampled_data=sampled_data, scale=scale) | ||
|
|
||
| if send_min_sample_warning: | ||
| warn_msg = ( | ||
| "The 'scale' parameter it too small. Some tables may have 1 row." |
There was a problem hiding this comment.
typo: "The 'scale' parameter it too small." -> "The 'scale' parameter is too small."
fealho
reviewed
Jun 13, 2024
Added a unit test to show |
fealho
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2045
CU-86b0reety
Make sure that the minimum size of root tables of 1 is used for sampling of small scales to avoid errors. Throw a warning that sample size should be bigger for better quality data as cardinality will likely no be accurate.