Release notes should not include PRs #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
reviewed
Jun 20, 2024
Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
gsheni
reviewed
Jun 20, 2024
| @@ -23,6 +23,14 @@ | |||
| 'feature request', | |||
| 'customer success', | |||
| ] | |||
| ISSUE_LABELS_ORDERED_BY_IMPORTANCE = [ | |||
There was a problem hiding this comment.
Would it be better to just change the order of ISSUE_LABELS to match what you want, rather than creating a new global variable?
There was a problem hiding this comment.
The other one is a different order because when picking which category to assign a label to, I want the order to be different. For example, if an issue is labeled both a feature request and internal, I want it to be only put in the internal category of the release notes. So the order for ISSUE_LABELS is intentionally different
gsheni
approved these changes
Jun 20, 2024
rwedge
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2074
This PR also changes the order that each category appears in for the release notes to put features and customer issues at the top