-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a utility function get_random_sequence_subset
#2098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
sdv/utils/poc.py
Outdated
- last_rows: Keep the last n rows of the sequence, where n is the max sequence length. | ||
- random: Randomly choose n rows to keep within the sequence. It is important to keep | ||
the randomly chosen rows in the same order as they appear in the original data. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other poc/utils
methods start by validating the metadata
. It can be useful here also to prevent the case where the sequence_key inside the metadata is not in the data
c810b15
to
4f7887e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Just minor suggestions
resolves #2085
CU-86b0z70r1