Enable evaluation to work with new metadata #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvk-developer
requested review from
rwedge,
amontanez24 and
lajohn4747
and removed request for
a team and
rwedge
amontanez24
reviewed
Aug 6, 2024
sdv/evaluation/single_table.py
Outdated
| @@ -27,7 +28,14 @@ def evaluate_quality(real_data, synthetic_data, metadata, verbose=True): | |||
| Single table quality report object. | |||
| """ | |||
| quality_report = QualityReport() | |||
| quality_report.generate(real_data, synthetic_data, metadata.to_dict(), verbose) | |||
| if not isinstance(metadata, Metadata): | |||
| metadata = Metadata()._convert_to_unified_metadata(metadata) | |||
There was a problem hiding this comment.
This method converts the old metadata to a dict under the hood, then to the new metadata object. Then you convert it back to a dict below. Why not just convert it to a dict here and use that?
pvk-developer
force-pushed
the
issue-2130-enable-evaluation-to-work-with-new-metadata
branch
from
21c5a37
to
3946b5f
Compare
pvk-developer
force-pushed
the
issue-2130-enable-evaluation-to-work-with-new-metadata
branch
from
3946b5f
to
2e25c3f
Compare
pvk-developer
deleted the
issue-2130-enable-evaluation-to-work-with-new-metadata
branch
This was referenced Aug 8, 2024
R-Palazzo
pushed a commit
that referenced
this pull request
Sep 19, 2024
R-Palazzo
pushed a commit
that referenced
this pull request
Sep 24, 2024
R-Palazzo
pushed a commit
that referenced
this pull request
Sep 26, 2024
R-Palazzo
pushed a commit
that referenced
this pull request
Sep 26, 2024
amontanez24
pushed a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2130