Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement datetime downcasting for accurate column comparison in constraints #2293

Conversation

pvk-developer
Copy link
Member

Resolves #2275
CU-86b2q1p22

@sdv-team
Copy link
Contributor

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (39f060e) to head (7aec460).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2293   +/-   ##
=======================================
  Coverage   98.64%   98.65%           
=======================================
  Files          58       58           
  Lines        6050     6078   +28     
=======================================
+ Hits         5968     5996   +28     
  Misses         82       82           
Flag Coverage Δ
integration 82.31% <100.00%> (+0.08%) ⬆️
unit 97.48% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvk-developer pvk-developer marked this pull request as ready for review November 13, 2024 20:54
@pvk-developer pvk-developer requested a review from a team as a code owner November 13, 2024 20:54
@pvk-developer pvk-developer requested review from frances-h and removed request for a team November 13, 2024 20:54
sdv/constraints/utils.py Outdated Show resolved Hide resolved
sdv/constraints/utils.py Outdated Show resolved Hide resolved
sdv/constraints/utils.py Outdated Show resolved Hide resolved
sdv/constraints/tabular.py Show resolved Hide resolved
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pvk-developer pvk-developer force-pushed the issue-2275-inequality-constraint-cannot-be-applied-to-compare-datetime-to-date branch from 416f4d8 to 62d4771 Compare November 15, 2024 12:07
@pvk-developer pvk-developer force-pushed the issue-2275-inequality-constraint-cannot-be-applied-to-compare-datetime-to-date branch from 62d4771 to 7aec460 Compare November 15, 2024 13:11
@pvk-developer pvk-developer merged commit d16f31c into main Nov 15, 2024
41 checks passed
@pvk-developer pvk-developer deleted the issue-2275-inequality-constraint-cannot-be-applied-to-compare-datetime-to-date branch November 15, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inequality constraint cannot be applied to compare datetime to date
4 participants