Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py39 to github workflows #649

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Nov 23, 2021

issue #631

@amontanez24
Copy link
Contributor

While you're doing this, can we add 3.9 here as well?

SDV/setup.py

Lines 89 to 93 in 08bed6d

'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
],

I missed this in the original PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #649 (76324e7) into master (08bed6d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #649   +/-   ##
=======================================
  Coverage   64.92%   64.92%           
=======================================
  Files          34       34           
  Lines        2583     2583           
=======================================
  Hits         1677     1677           
  Misses        906      906           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bed6d...76324e7. Read the comment docs.

@katxiao katxiao marked this pull request as ready for review November 23, 2021 17:58
@katxiao katxiao requested a review from a team as a code owner November 23, 2021 17:58
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for finding this and fixing!

@katxiao katxiao merged commit 1a6a703 into master Nov 23, 2021
@katxiao katxiao deleted the issue-631-py39-github-workflows branch November 23, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants