Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality to read and merge gender data to author data #216

Merged
merged 29 commits into from
Dec 21, 2021
Merged

Add functionality to read and merge gender data to author data #216

merged 29 commits into from
Dec 21, 2021

Commits on Oct 27, 2021

  1. Add function 'read.gender' 

    Add the function 'read.gender' to read gender data that contains
2 columns: name;gender

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    8868ff4 View commit details
    Browse the repository at this point in the history

  2. Add functions to merge gender data to author data 

    Add the base functions 'get.data.path.gender', 'get.gender', 'set.gender',
and 'update.gender.data' to manage gender data

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    bfbe4de View commit details
    Browse the repository at this point in the history

  3. Add gender related configuration attributes 

    Add gender related configurations to 'util-conf.R' file

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    0a23862 View commit details
    Browse the repository at this point in the history

  4. Add a test and sample data for the 'read.gender' 

    Add test, test data, and sample data to test the 'read.gender' function.

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    a7744b5 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Add new changes regarding gender data to NEWS.md 

    Add description of new functionalities related to gender data to the
NEWS.md

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    1eeca29 View commit details
    Browse the repository at this point in the history

  2. Add a folder 'test_empty_gender' in the test data 

    Include a folder 'test_empty_gender' with an empty 'gender' file in it in the test data folder.

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    6a50fd1 View commit details
    Browse the repository at this point in the history

  3. Place gender section below author section 

    Move functions related to gender data to the 'additional data sources'
section to keep a meaningful order of the sections.

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    53ef8cd View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary comment regarding gender file 

    Remove the sentence regarding the form of the gender file

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    d795dac View commit details
    Browse the repository at this point in the history

  5. Reorder functions in util-read.R 

    Reorder functions in util-read.R file to keep meaningful order of the
functions.

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    faa5b34 View commit details
    Browse the repository at this point in the history

  6. Reorder attributes in the util-conf.R 

    Reorder attributes in the util-conf.R to keep the meaningfull order

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    15edca6 View commit details
    Browse the repository at this point in the history

  7. Reorder data paths in util-conf.R 

    Reorder data paths in util-conf.R to keep meaningfull order

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    2f8480b View commit details
    Browse the repository at this point in the history

  8. Refactor read.gender function to reduce complexity 

    Refactor read.gender function to reduce complexity removing separators
and etc.

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    c332c91 View commit details
    Browse the repository at this point in the history

  9. Refactor functions related to gender in util-data 

    Improvements:
 - Reordering functions
 - Reordering configuration parameters
 - Fixing typos in comments

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    5c50742 View commit details
    Browse the repository at this point in the history

  10. Replace is.null with empty for gender data 

    Use empty function to check if the gender data frame is empty.

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    cf2cce8 View commit details
    Browse the repository at this point in the history

  11. Add ".list" ending to the gender file 

    Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    cd99e5c View commit details
    Browse the repository at this point in the history

  12. Add "cleanup.gender.data" function 

    Add "cleanup.geder.data" function to remove all lines from the gender
data that contain author names that do not appear in the author data

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    413e24c View commit details
    Browse the repository at this point in the history

  13. Reorder tests in "test-read.R" and fix typo 

    Reorder tests in "test-read.R" file

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    cbcd552 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Add gender data to ProjectData comparison tests 

    - Add gender data to ProjectData comparison tests in test-data.R
- Rename gender files from 'gender' to 'gender.list'

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    39db315 View commit details
    Browse the repository at this point in the history

  2. Add info about fixed errors to NEWS.md 

    Added explanation about fixed errors to NEWS.md

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    85c3056 View commit details
    Browse the repository at this point in the history

  3. Add gender data to the necessary section of README 

    - Add gender data to the tests/README.md
- Add gender data to the README.md

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    bc30c40 View commit details
    Browse the repository at this point in the history

  4. Fix failing test due to updated igraph calculation 

    Since igraph has changed the calculation of eigenvector centrality with
version '1.2.7', the test for this had to be changed to the correct
values. Also add a warning message in the install.R script that we
recommend igraph version 1.2.7 or higher. Also document this in the
README.

Signed-off-by: Christian Hechtl <hechtl@cs.uni-saarland.de>
Signed-off-by: Thomas Bock <bockthom@cs.uni-saarland.de>

Applied-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    @hechtlC
    hechtlC authored and Mirabdulla Yusifli committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    25fb862 View commit details
    Browse the repository at this point in the history

  5. Fix filtering of the deleted user 

    As documented in se-sic#214 we have to make the deleted user to lowercase as
this user can appear in all variations of upper and lowercase letters.
So by making this lowercase, we fix this.

Signed-off-by: Christian Hechtl <hechtl@cs.uni-saarland.de>
Signed-off-by: Thomas Bock <bockthom@cs.uni-saarland.de>

Applied-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    @hechtlC
    hechtlC authored and Mirabdulla Yusifli committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    1b4072c View commit details
    Browse the repository at this point in the history

  6. Add gender to necessary additional resource lists 

    Add gender data to necessary additional resource lists to pass
the tests successfully

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    c3ada92 View commit details
    Browse the repository at this point in the history

  7. Restrict gender labels by predefined lables 

     - Allow only 'male', 'female', 'unknown' lables for the gender column.
 - Replace all undefined lables with 'unknown'
 - Replace all 'unknown' lables with NA

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    1e4026d View commit details
    Browse the repository at this point in the history

  8. Update gender test because of predefined lables 

    Update gender test and its data because of predefined labels

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    be56183 View commit details
    Browse the repository at this point in the history

  9. Reorder functions in util-data.r 

    Reorder functions and fix small formatting issues in util-data.r

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    4d631bd View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2021

  1. Remove rownames while reading gender data 

    - Remove rownames while reading gender data
- Fix some formatting issues

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    8769ccf View commit details
    Browse the repository at this point in the history

  2. Edit information about gender data in README.md 

    There are no edge attributes for gender. Therefore,
edit information about gender data in README.md

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    50292cb View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Update broken commit hashes in NEWS.md 

    Update broken commit hashes related gender data in NEWS.md

Signed-off-by: Mirabdulla Yusifli <s8miyusi@stud.uni-saarland.de>
    Mirabdulla Yusifli authored and Mirabdulla Yusifli committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    17811be View commit details
    Browse the repository at this point in the history