Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: optimize app instruction #1981

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

starnop
Copy link
Collaborator

@starnop starnop commented Jan 16, 2023

Signed-off-by: yuxing.lyx yuxing.lyx@alibaba-inc.com

Describe what this PR does / why we need it

Does this pull request fix one issue?

related issue #1968

Describe how you did it

Describe how to verify it

Special notes for reviews

@github-actions github-actions bot added ImageBuilding related to all staff with image building test labels Jan 16, 2023
@starnop starnop force-pushed the optimize-app-instruction branch from e3fbd53 to baaddb3 Compare January 16, 2023 05:23
@github-actions github-actions bot removed the test label Jan 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Base: 18.05% // Head: 17.99% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (f4cae88) compared to base (91ba640).
Patch coverage: 8.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1981      +/-   ##
==========================================
- Coverage   18.05%   17.99%   -0.07%     
==========================================
  Files         104      104              
  Lines        9311     9360      +49     
==========================================
+ Hits         1681     1684       +3     
- Misses       7411     7454      +43     
- Partials      219      222       +3     
Impacted Files Coverage Δ
build/kubefile/parser/kubefile.go 36.82% <0.00%> (-7.41%) ⬇️
pkg/define/image/v1/sealer_image_extension.go 0.00% <ø> (ø)
pkg/application/v2app.go 54.28% <33.33%> (-3.78%) ⬇️
build/kubefile/parser/parse.go 56.21% <100.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@starnop starnop force-pushed the optimize-app-instruction branch 2 times, most recently from a79d5d3 to 9006a71 Compare January 16, 2023 05:56
Signed-off-by: yuxing.lyx <yuxing.lyx@alibaba-inc.com>
@starnop starnop force-pushed the optimize-app-instruction branch from 9006a71 to f4cae88 Compare January 16, 2023 06:06
Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakaZhou719 kakaZhou719 merged commit 8abe153 into sealerio:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImageBuilding related to all staff with image building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants