Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAMSECURITY-98 #44

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

SEAMSECURITY-98 #44

wants to merge 4 commits into from

Conversation

nheron
Copy link
Contributor

@nheron nheron commented Jan 3, 2013

Hello
https://issues.jboss.org/browse/SEAMSECURITY-98
I do a pull request again as it is really needed to support jaas authentification.
Thanks
Nicolas Héron

@lincolnthree
Copy link
Member

Hi Nicolas,

Thanks for your contribution! Your changes look good, but there are some problems with your pull request:

https://github.com/seam/security/pull/44/files

You have changed the version of the project, and also added several repositories to the POM file. These repositories should instead be configured in your ~/.m2/settings.xml file.

You should also create a branch to keep your changes separate from your master branch (and more stable so new commits don't get added to the PR), you'll also need squash any multiple commits down to one single commit for the branch/pull request using git rebase -i HEAD~{number of commits to squash}

Thanks for the accommodation!
~Lincoln

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants