Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support Chinese caption video #15

Closed
thisisowenlo opened this issue Apr 24, 2023 · 2 comments · Fixed by #16
Closed

[FEATURE] Support Chinese caption video #15

thisisowenlo opened this issue Apr 24, 2023 · 2 comments · Fixed by #16
Assignees
@sean1832
Labels
enhancement New feature or request

Comments

@thisisowenlo
Copy link

I tried to summarize a youtube video with Chinese (traditional) subtitles and it tells me the following message：

❌ Caption language currently not supported.

{'zh-TW': <Caption lang="Chinese (Taiwan)" code="zh-TW">}

Describe the solution you'd like

Would like to request a feature to support this kind of video.
@thisisowenlo thisisowenlo added the enhancement New feature or request label Apr 24, 2023
@sean1832
Copy link
Owner

Hello, could you please share the YouTube link as a reference? Thank you.

@thisisowenlo
Copy link
Author

Hi,

This is the video link I tried to summarize: https://www.youtube.com/watch?v=7VdhEE194fc

Thanks!

@sean1832 sean1832 linked a pull request Apr 24, 2023 that will close this issue
feat: add caption language support for "zh-TW" #16
Merged
sean1832 added a commit that referenced this issue Apr 24, 2023
@sean1832
Merge pull request #16 from sean1832/15-feature-support-chinese-capti…
e760e96 
…on-video

feat: add caption language support for "zh-TW" #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sean1832 sean1832

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add caption language support for "zh-TW" sean1832/SumGPT
2 participants
@thisisowenlo @sean1832