This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
Alternative pull request with EOL translation in process() #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes fixing a bug in telnet_translate_eol() for the case where there are multiple CRLF instances in one buffer.
The translation is enabled by a new bit in telnet_init() flags parameter. Remove telnet_translate_eol() since that function is subsumed.
seanmiddleditch
approved these changes
Sep 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaner solution in that the application does not have to call a separate telnet_translate_eol() function that makes another pass over the data. It also avoids the eol_was_split boolean that must be kept by the application. However, it does touch more of the previously existing code.