Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default timeouts #181

Closed
seanmonstar opened this issue Aug 9, 2017 · 2 comments
Closed

Default timeouts #181

seanmonstar opened this issue Aug 9, 2017 · 2 comments
Labels
B-rfc Blocked: Request for comments. More discussion would help move this along.
Milestone

Comments

@seanmonstar
Copy link
Owner

Not having a default timeout means that anyone who doesn't consider a maximum time length for a request can end up with a hung thread (with sync client) for quite a while. This could even not manifest during testing and development, and only happen in rare occasions in production, where the long hang without a cancel hurts a user.

Now, some people need a really long timeout, such as if doing "long polling", or on flaky wireless connections. But as long as there is an option for them to increase (disable?) the timeout, they should be fine.

So, what's a proper default? 30 seconds?

@seanmonstar seanmonstar modified the milestone: 0.8 Aug 18, 2017
@seanmonstar seanmonstar added the B-rfc Blocked: Request for comments. More discussion would help move this along. label Aug 19, 2017
@KodrAus
Copy link
Contributor

KodrAus commented Aug 24, 2017

30 seconds seems like plenty of time in most cases. I think if you're possibly going to need more time than that in normal circumstances then you'll probably know about it.

FWIW .NET's http client decided on 100 seconds for their default timeout.

@AndreKR
Copy link

AndreKR commented Jun 27, 2020

Ok, I find a default timeout a bit surprising, but I can understand the decision. However, there's no way to disable the timeout per request, is there? Just set it to 1 week or so? I'm uploading some files, which can easily take hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-rfc Blocked: Request for comments. More discussion would help move this along.
Projects
None yet
Development

No branches or pull requests

3 participants