-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http2 feature to allow disabling HTTP/2 support #1648
Conversation
8928d4b
to
3e4fc50
Compare
This would indeed be a good addition, but it's a breaking change, so we need to bundle it with the next breaking release (not yet scheduled, but will follow hyper 1.0). |
When do you expect that to happen? Are we talking about weeks, months or years? |
hyper 1.0 is a couple months away. After that, updating reqwest will happen soon after. |
What if I revert the logic – add |
Adding a feature like that can cause breakage. If anyone in the dependency tree enabled the feature, it would disable HTTP/2 for any other crate that expected it to work. |
The HTTP/2 support requires the h2 crate which is quite a heavy dependency. Resolves seanmonstar#1137
FYI this breaks |
FYI, we've found a bug in this PR, where reqwest will fail to communicate with a hybrid HTTP1+2 server with TLS enabled when reqwest is built with HTTP2 disabled. This seems to happen when doing ALPN negotiation, so presumably all of the |
This will be part of 0.12, and was merged in #2162. |
The HTTP/2 support requires the h2 crate which is quite a heavy dependency.
Resolves #1137
All tests are green: https://github.com/jirutka/reqwest/actions/runs/3222094053 (requering approval to run CI jobs in pull requests from new contributors is quite annoying default).