Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not negotiate h2 when using native-tls backend with feature native-tls-alpn enabled #2165

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

cxw620
Copy link
Contributor

@cxw620 cxw620 commented Mar 9, 2024

fix: not negotiate h2 when using native-tls backend with feature native-tls-alpn enabled.

@cxw620 cxw620 force-pushed the patch-h2 branch 2 times, most recently from c41ce8e to 2674588 Compare March 11, 2024 15:38
@cxw620
Copy link
Contributor Author

cxw620 commented Mar 11, 2024

I've tested this PR with the following minimum example:

#[tokio::main]
async fn main() {
    // tracing_subscriber::registry().with(fmt::layer()).init();
    let client = reqwest::Client::builder()
        .use_native_tls()
        // .use_rustls_tls()
        // .proxy(reqwest::Proxy::all("socks5://127.0.0.1:20023").unwrap()) // without patch from this PR, enable proxy may cause panic with error `hyper::Error(Parse(Version))`. Unknown reason.
        .build()
        .unwrap();
    let version = client
        .get("https://google.com/")
        .send()
        .await
        .unwrap()
        .version();
    println!("{:?}", version); // should get HTTP/2.0 instead of HTTP/1.1
}
[dependencies]
reqwest = { version = "0.11.25", features = [
    # "rustls-tls",
    "native-tls-alpn",
    "socks",
] }
tokio = { version = "1.36.0", features = ["full"] }

@cxw620
Copy link
Contributor Author

cxw620 commented Mar 22, 2024

@seanmonstar Could you provide an update on this PR? Any feedback or comments on it? Thanks :D

@seanmonstar seanmonstar merged commit 056f8c4 into seanmonstar:master Mar 22, 2024
33 checks passed
@cxw620 cxw620 deleted the patch-h2 branch March 23, 2024 17:35
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Mar 26, 2024
Bumps reqwest from 0.12.1 to 0.12.2.

Release notes
Sourced from reqwest's releases.

v0.12.2
What's Changed

Fix missing ALPN when connecting to socks5 proxy with rustls.
Fix TLS version limits with rustls.
Fix not detected ALPN h2 from server with native-tls.

New Contributors

@​cxw620 made their first contribution in seanmonstar/reqwest#2165

Full Changelog: seanmonstar/reqwest@v0.12.1...v0.12.2



Changelog
Sourced from reqwest's changelog.

v0.12.2

Fix missing ALPN when connecting to socks5 proxy with rustls.
Fix TLS version limits with rustls.
Fix not detected ALPN h2 from server with native-tls.




Commits

6768a8e v0.12.2
fff307b fix(connect): ALPN missed when using socks5 proxy with rustls backend (#2164)
04bf45f fix: tls version limit for rustls (#2203)
056f8c4 fix(connect): not negotiate h2 when using native-tls backend (#2165)
See full diff in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants