-
-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking Change: replace Reject
trait with Into<Rejection>
#527
Conversation
do not mergeThis trait doesn't yet solve the problem I care about, in fact it makes it worse, I still haven't been able to figure out how to have The best idea I have rn is to just drop the |
One thing to note is that the rejection system in warp is purposefully not meant to be |
Reject
trait with Into<Rejection>
well that works out because basing it on std error was not possible without specialization afaik. The "remove Debug on Rejection" solution ended up working, bonus points is now when type inferences lets you you can use |
Got it working and passing tests, not being able to just |
Thanks for the PR! I'm inclined to keep the |
That's fair, I probably wont push on this because I was only using warp for a small side project that ended up getting discarded but if someone else ends up asking about it or said |
I'm not sure this is the best approach yet but the goal rn it to make it so warp can support 3rd party error types like
anyhow
andeyre
without those types having to have a conditional dependency on warp just to impl the Reject trait.