css reset should not be inlined #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jjb I think the #outlook and .ExternalClass are added by Outlook and Hotmail respectively when those clients render the e-mail. Unless I'm missing something the #outlook and .ExternalClass don't exist when you go to inline css, before you send the e-mail. |
|
@lkrids ahhh, gotcha. have a reference handy? |
|
@jjb I'm just going off of the comments in the code. There are no elements in the boilerplate with #outlook or .ExternalClass. |
|
hi, this pr is a bit old and i'm not sure it's still valuable... but you may find some references here : thanks for your work. |
this is a thorough description of the test I'm performing now.
got email from team
tchalvak
pushed a commit
to BitLucid/Email-Boilerplate
that referenced
this pull request
Oct 20, 2018
tenitski
reviewed
May 1, 2020
| @@ -225,7 +225,7 @@ | |||
| <a href="http://htmlemailboilerplate.com" target ="_blank" title="Styling Links" style="color: orange; text-decoration: none;">Coloring Links appropriately</a> | |||
|
|
|||
| <!-- Gmail/Hotmail image display fix: Gmail and Hotmail unwantedly adds in an extra space below images when using non IE browsers. This can be especially painful when you putting images on top of each other or putting back together an image you spliced for formatting reasons. Either way, you can add the 'image_fix' class to remove that space below the image. Make sure to set alignment (don't use float) on your images if you are placing them inline with text.--> | |||
| <img class="image_fix" src="full path to image" alt="Your alt text" title="Your title text" width="x" height="x" /> | |||
| <img class="image_fix" src="full asdf to image" alt="Your alt text" title="Your title text" width="x" height="x" /> | |||
tenitski
reviewed
May 1, 2020
| @@ -1,7 +1,7 @@ | |||
| <!-- *************************************************** | |||
| ******************************************************** | |||
|
|
|||
| HOW TO USE: Use these code examples as a guideline for formatting your HTML email. You may want to create your own template based on these snippets or just pick and choose the ones that fix your specific rendering issue(s). There are two main areas in the template: 1. The header (head) area of the document. You will find global styles, where indicated, to move inline. 2. The body section contains more specific fixes and guidance to use where needed in your design. | |||
| HOW TOasdf USE: Use these code examples as a guideliasdfne for formatting your HTML email. You may want to create your own template based on these snippets or just pick and choose the ones that fix your specific rendering issue(s). There are two main areas in the template: 1. The header (head) area of the document. You will find global styles, where indicated, to move inline. 2. The body section contains more specific fixes and guidance to use where needed in your design. | |||
tenitski
reviewed
May 1, 2020
| @@ -206,7 +206,7 @@ | |||
| </head> | |||
| <body> | |||
| <!-- Wrapper/Container Table: Use a wrapper table to control the width and the background color consistently of your email. Use this approach instead of setting attributes on the body tag. --> | |||
| <table cellpadding="0" cellspacing="0" border="0" id="backgroundTable"> | |||
| <table cellpadding="0" cellspacing="0" border="5" id="backgroundTable"> | |||
There was a problem hiding this comment.
Why was it set to 5? There is no explanation anywhere...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The css reset is styling or resetting elements that are added by email clients. These css rules shouldn't be inlined.