-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css reset should not be inlined #26
Conversation
@jjb I think the #outlook and .ExternalClass are added by Outlook and Hotmail respectively when those clients render the e-mail. Unless I'm missing something the #outlook and .ExternalClass don't exist when you go to inline css, before you send the e-mail. |
@lkrids ahhh, gotcha. have a reference handy? |
@jjb I'm just going off of the comments in the code. There are no elements in the boilerplate with #outlook or .ExternalClass. |
hi, this pr is a bit old and i'm not sure it's still valuable... but you may find some references here : thanks for your work. |
this is a thorough description of the test I'm performing now.
got email from team
@@ -225,7 +225,7 @@ | |||
<a href="http://htmlemailboilerplate.com" target ="_blank" title="Styling Links" style="color: orange; text-decoration: none;">Coloring Links appropriately</a> | |||
|
|||
<!-- Gmail/Hotmail image display fix: Gmail and Hotmail unwantedly adds in an extra space below images when using non IE browsers. This can be especially painful when you putting images on top of each other or putting back together an image you spliced for formatting reasons. Either way, you can add the 'image_fix' class to remove that space below the image. Make sure to set alignment (don't use float) on your images if you are placing them inline with text.--> | |||
<img class="image_fix" src="full path to image" alt="Your alt text" title="Your title text" width="x" height="x" /> | |||
<img class="image_fix" src="full asdf to image" alt="Your alt text" title="Your title text" width="x" height="x" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental edit here?
@@ -1,7 +1,7 @@ | |||
<!-- *************************************************** | |||
******************************************************** | |||
|
|||
HOW TO USE: Use these code examples as a guideline for formatting your HTML email. You may want to create your own template based on these snippets or just pick and choose the ones that fix your specific rendering issue(s). There are two main areas in the template: 1. The header (head) area of the document. You will find global styles, where indicated, to move inline. 2. The body section contains more specific fixes and guidance to use where needed in your design. | |||
HOW TOasdf USE: Use these code examples as a guideliasdfne for formatting your HTML email. You may want to create your own template based on these snippets or just pick and choose the ones that fix your specific rendering issue(s). There are two main areas in the template: 1. The header (head) area of the document. You will find global styles, where indicated, to move inline. 2. The body section contains more specific fixes and guidance to use where needed in your design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another accidental edit?
@@ -206,7 +206,7 @@ | |||
</head> | |||
<body> | |||
<!-- Wrapper/Container Table: Use a wrapper table to control the width and the background color consistently of your email. Use this approach instead of setting attributes on the body tag. --> | |||
<table cellpadding="0" cellspacing="0" border="0" id="backgroundTable"> | |||
<table cellpadding="0" cellspacing="0" border="5" id="backgroundTable"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was it set to 5? There is no explanation anywhere...
The css reset is styling or resetting elements that are added by email clients. These css rules shouldn't be inlined.