fix #98: fix rejectUnauthorized option value #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current value for rejectUnauthorized is set in this way: ```javascript this.rejectUnauthorized = settings.rejectUnauthorized || true; ``` but if in the constructor we pass the value `false` it will resolve in `false || true` which is true. I've tested this change and it seems to work when using self-signed SSL certificates. This commit will only include the src file as I don't know if to include the compiled assets. note: in the issue seantomburke#98 @AntonKrutikov suggested this change ```javascript this.rejectUnauthorized = settings.rejectUnauthorized ?? true; ``` but it will not be transpiled correctly so I used the "old fashion" style and `npm run compile` worked correctly.
|
We'll need to generate the files though, I can create a follow up PR commit to have those changes propagate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current value for rejectUnauthorized is set in this way:
but if in the constructor we pass the value
falseit will resolve infalse || truewhich is true.I've tested this change and it seems to work when using self-signed SSL certificates.
This commit will only include the src file as I don't know if to include the compiled assets.
note: in the issue #98 @AntonKrutikov suggested this change
but it will not be transpiled correctly so I used the "old fashion" style and
npm run compileworked correctly.