Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option rejectUnauthorized to disable tls certificate validation #96

Merged
merged 7 commits into from
Dec 24, 2021

Conversation

seantomburke
Copy link
Owner

@seantomburke seantomburke commented Dec 23, 2021

@seantomburke seantomburke changed the title Resolving Conflicts in #95 (Hipex bv master) Added option rejectUnauthorized to disable tls certificate validation (Resolving Conflicts in #95 (Hipex bv master)) Dec 23, 2021
@seantomburke seantomburke changed the title Added option rejectUnauthorized to disable tls certificate validation (Resolving Conflicts in #95 (Hipex bv master)) Added option rejectUnauthorized to disable tls certificate validation Dec 23, 2021
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 23, 2021
kirdia and others added 6 commits December 23, 2021 15:56
Support request to sites with invalid certificates (development)
* New features & updated documentation

* Ability to report on sitemap crawl errors in returned results. Added a new "errors" property in the `SitesData` object

* Added an option to set a concurrency limit to rate limit sitemap crawling. Useful when crawling sitemaps with multiple children to avoid getting blocked by firewalls. #77

* Added an option to have retry requests upon failure and to set the number of maximum retries per crawl.

* Updated documentation to include all the new features described above.

Co-Authored-By: Panagiotis Tzamtzis <panagiotis@baresquare.com>
Co-Authored-By: PanagiotisTzamtzis <panagiotis@tzamtzis.gr>

* Fix for error on the main sitemap

In this case the errors object in the results was not an ErrorsDataArray but a single ErrorsData

* Bug fixes

* Error logging improvements with more details for `UnknownStateErrors` & errors when parsing the parent sitemap

* Retries option was not working when `debug` was set to false

* Bug fix

* Console.log statement was getting triggered when `debug` option was set to false

* Update src/examples/index.js

* 3.2.0

* Cleaning up, changing error to errors, updating Typescript, removing returnErrors option

* Removing returnErrors option

* quotes fix

* Updates

* Fixing errors array

* updating tests

Co-authored-by: PanagiotisTzamtzis <panagiotis@tzamtzis.gr>
Co-authored-by: Sean Thomas Burke <965298+seantomburke@users.noreply.github.com>
Co-authored-by: Sean Thomas Burke <seantomburke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants