Java and Spring Version Migration #101

dabico · 2023-06-14T14:29:31Z

Java LTS version change: 11 -> 17
Spring Boot version change: 2.7.10 -> 3.1.0
javax relocation to jakarta
springdoc-openapi relocation

Checklist:

These are components aimed at isolating the link construction behaviour for the search. Subsequent commits will replace the old code in favor of these new components.

… fields to total* fields

… overall* metrics to total*

Bumps nginx from 1.23.3-alpine-slim to 1.25.1-alpine-slim. --- updated-dependencies: - dependency-name: nginx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…elop/nginx-1.25.1-alpine-slim

Our custom override will only be used in production

Will have the same contents as the console output. Not persisted between runs.

dabico · 2023-06-20T12:53:39Z

Not sure if we can merge this into develop just yet because we introduced administration support in 1a5b354
(SBA 3.0.X might not work with SB 3.1.X)

…`develop`" This reverts commit 3391bf2.

This reverts commit 295a19a.

This reverts commit a99afee.

dabico · 2023-06-20T13:46:38Z

Given that all the checks pass now, I wanted to run the application and see if the features we integrated so far work. Turns out the crawler throws this bizarre exception on startup:

Stacktrace

2023-06-20T15:34:28.512+02:00 ERROR 4492 --- [     GHSThread1] .c.SchedulerConfig$SchedulerErrorHandler : Unhandled exception occurred while performing a scheduled job.

org.springframework.dao.InvalidDataAccessApiUsageException: org.springframework.data.jpa.repository.query.BadJpqlGrammarException: Line 6:26 extraneous input 'first' expecting <EOF>; Bad JPQL grammar [select sl
from SupportedLanguage sl
left join CrawlJob cj
on cj.language.id = sl.id
where sl.name in (:names)
order by cj.crawled nulls first]
	at org.springframework.orm.jpa.EntityManagerFactoryUtils.convertJpaAccessExceptionIfPossible(EntityManagerFactoryUtils.java:371) ~[spring-orm-6.0.9.jar:6.0.9]
	at org.springframework.orm.jpa.vendor.HibernateJpaDialect.translateExceptionIfPossible(HibernateJpaDialect.java:234) ~[spring-orm-6.0.9.jar:6.0.9]
	at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.translateExceptionIfPossible(AbstractEntityManagerFactoryBean.java:550) ~[spring-orm-6.0.9.jar:6.0.9]
	at org.springframework.dao.support.ChainedPersistenceExceptionTranslator.translateExceptionIfPossible(ChainedPersistenceExceptionTranslator.java:61) ~[spring-tx-6.0.9.jar:6.0.9]
	at org.springframework.dao.support.DataAccessUtils.translateIfNecessary(DataAccessUtils.java:242) ~[spring-tx-6.0.9.jar:6.0.9]
	at org.springframework.dao.support.PersistenceExceptionTranslationInterceptor.invoke(PersistenceExceptionTranslationInterceptor.java:152) ~[spring-tx-6.0.9.jar:6.0.9]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184) ~[spring-aop-6.0.9.jar:6.0.9]
	at org.springframework.data.jpa.repository.support.CrudMethodMetadataPostProcessor$CrudMethodMetadataPopulatingMethodInterceptor.invoke(CrudMethodMetadataPostProcessor.java:134) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184) ~[spring-aop-6.0.9.jar:6.0.9]
	at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97) ~[spring-aop-6.0.9.jar:6.0.9]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184) ~[spring-aop-6.0.9.jar:6.0.9]
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:223) ~[spring-aop-6.0.9.jar:6.0.9]
	at jdk.proxy2/jdk.proxy2.$Proxy176.findAllByNameInOrderByCrawled(Unknown Source) ~[na:na]
	at usi.si.seart.service.SupportedLanguageService$SupportedLanguageServiceImpl.getQueue(SupportedLanguageService.java:38) ~[classes/:na]
	at usi.si.seart.job.CrawlProjectsJob.run(CrawlProjectsJob.java:89) ~[classes/:na]
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[na:na]
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:na]
	at java.base/java.lang.reflect.Method.invoke(Method.java:568) ~[na:na]
	at org.springframework.scheduling.support.ScheduledMethodRunnable.run(ScheduledMethodRunnable.java:84) ~[spring-context-6.0.9.jar:6.0.9]
	at org.springframework.scheduling.support.DelegatingErrorHandlingRunnable.run(DelegatingErrorHandlingRunnable.java:54) ~[spring-context-6.0.9.jar:6.0.9]
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[na:na]
	at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) ~[na:na]
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) ~[na:na]
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[na:na]
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[na:na]
	at java.base/java.lang.Thread.run(Thread.java:833) ~[na:na]
Caused by: java.lang.IllegalArgumentException: org.springframework.data.jpa.repository.query.BadJpqlGrammarException: Line 6:26 extraneous input 'first' expecting <EOF>; Bad JPQL grammar [select sl
from SupportedLanguage sl
left join CrawlJob cj
on cj.language.id = sl.id
where sl.name in (:names)
order by cj.crawled nulls first]
	at org.springframework.data.jpa.repository.query.JpaQueryParserSupport.renderSortedQuery(JpaQueryParserSupport.java:56) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.JpaQueryEnhancer.applySorting(JpaQueryEnhancer.java:88) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.JpaQueryEnhancer.applySorting(JpaQueryEnhancer.java:100) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.AbstractStringBasedJpaQuery.doCreateQuery(AbstractStringBasedJpaQuery.java:96) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.AbstractJpaQuery.createQuery(AbstractJpaQuery.java:234) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.JpaQueryExecution$CollectionExecution.doExecute(JpaQueryExecution.java:129) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.JpaQueryExecution.execute(JpaQueryExecution.java:92) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.AbstractJpaQuery.doExecute(AbstractJpaQuery.java:148) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.AbstractJpaQuery.execute(AbstractJpaQuery.java:136) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.repository.core.support.RepositoryMethodInvoker.doInvoke(RepositoryMethodInvoker.java:136) ~[spring-data-commons-3.1.0.jar:3.1.0]
	at org.springframework.data.repository.core.support.RepositoryMethodInvoker.invoke(RepositoryMethodInvoker.java:120) ~[spring-data-commons-3.1.0.jar:3.1.0]
	at org.springframework.data.repository.core.support.QueryExecutorMethodInterceptor.doInvoke(QueryExecutorMethodInterceptor.java:164) ~[spring-data-commons-3.1.0.jar:3.1.0]
	at org.springframework.data.repository.core.support.QueryExecutorMethodInterceptor.invoke(QueryExecutorMethodInterceptor.java:143) ~[spring-data-commons-3.1.0.jar:3.1.0]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184) ~[spring-aop-6.0.9.jar:6.0.9]
	at org.springframework.data.projection.DefaultMethodInvokingMethodInterceptor.invoke(DefaultMethodInvokingMethodInterceptor.java:77) ~[spring-data-commons-3.1.0.jar:3.1.0]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184) ~[spring-aop-6.0.9.jar:6.0.9]
	at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:123) ~[spring-tx-6.0.9.jar:6.0.9]
	at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:391) ~[spring-tx-6.0.9.jar:6.0.9]
	at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:119) ~[spring-tx-6.0.9.jar:6.0.9]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184) ~[spring-aop-6.0.9.jar:6.0.9]
	at org.springframework.dao.support.PersistenceExceptionTranslationInterceptor.invoke(PersistenceExceptionTranslationInterceptor.java:137) ~[spring-tx-6.0.9.jar:6.0.9]
	... 21 common frames omitted
Caused by: org.springframework.data.jpa.repository.query.BadJpqlGrammarException: Line 6:26 extraneous input 'first' expecting <EOF>; Bad JPQL grammar [select sl
from SupportedLanguage sl
left join CrawlJob cj
on cj.language.id = sl.id
where sl.name in (:names)
order by cj.crawled nulls first]
	at org.springframework.data.jpa.repository.query.BadJpqlGrammarErrorListener.syntaxError(BadJpqlGrammarErrorListener.java:39) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.antlr.v4.runtime.ProxyErrorListener.syntaxError(ProxyErrorListener.java:41) ~[antlr4-runtime-4.10.1.jar:4.10.1]
	at org.antlr.v4.runtime.Parser.notifyErrorListeners(Parser.java:543) ~[antlr4-runtime-4.10.1.jar:4.10.1]
	at org.antlr.v4.runtime.DefaultErrorStrategy.reportUnwantedToken(DefaultErrorStrategy.java:377) ~[antlr4-runtime-4.10.1.jar:4.10.1]
	at org.antlr.v4.runtime.DefaultErrorStrategy.singleTokenDeletion(DefaultErrorStrategy.java:548) ~[antlr4-runtime-4.10.1.jar:4.10.1]
	at org.antlr.v4.runtime.DefaultErrorStrategy.recoverInline(DefaultErrorStrategy.java:467) ~[antlr4-runtime-4.10.1.jar:4.10.1]
	at org.antlr.v4.runtime.Parser.match(Parser.java:207) ~[antlr4-runtime-4.10.1.jar:4.10.1]
	at org.springframework.data.jpa.repository.query.HqlParser.start(HqlParser.java:252) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.HqlQueryParser.parseQuery(HqlQueryParser.java:53) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.HqlQueryParser.parse(HqlQueryParser.java:63) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.JpaQueryParserSupport$ParseState.lambda$new$0(JpaQueryParserSupport.java:182) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.util.Lazy.getNullable(Lazy.java:245) ~[spring-data-commons-3.1.0.jar:3.1.0]
	at org.springframework.data.util.Lazy.get(Lazy.java:114) ~[spring-data-commons-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.JpaQueryParserSupport$ParseState.getContext(JpaQueryParserSupport.java:194) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	at org.springframework.data.jpa.repository.query.JpaQueryParserSupport.renderSortedQuery(JpaQueryParserSupport.java:54) ~[spring-data-jpa-3.1.0.jar:3.1.0]
	... 41 common frames omitted

Seems to be a similar issue that was apparently resolved, but the fix is yet to appear in the next patch version. Guess we have to sit tight and wait for that as well before taking this any further.

dabico · 2023-06-22T07:15:00Z

Superseded by #108

dabico and others added 30 commits April 10, 2023 15:46

Added more configuration options to swagger-ui

ad21703

Changed configuration property group name

5104478

Added more settings

0dea78e

Added the @Tag annotation to the controllers

7dfa207

Added Operation and ApiResponse to RootController methods

7d13e0b

Added Operation and ApiResponse to SupportedLanguageController

7d98a20

Added Operation and ApiResponse to GitRepoController

c25e9c4

Modified object mapper bean declarations to use the builder pattern

e3f273b

Making some improvements to the extension logic

665607f

Added LinkBuilder hierarchy

e476b3d

These are components aimed at isolating the link construction behaviour for the search. Subsequent commits will replace the old code in favor of these new components.

Replacing usages of old link building code with new components

9b63f5b

Changing exposed headers to only the custom ones used for links

a4f8ad1

Merge pull request #56 from seart-group/documentation/swagger

8fb28f6

Bugfix: Avoid IndexOutOfBoundsException for missing build properties

a220e65

Created index

d0b0055

Added computed fields for overall code metrics

16fa48c

Fixed and integrated new implementation

6714a0b

Fixed join

f6fb204

Added tooltip

95e277d

Changed icon

655f6c0

Rephrased for clarity

994fe7a

Added export of metrics

f4bfb77

Discarded blanklines metric in favor of total lines. Renamed overall*…

c4f58a4

… fields to total* fields

Discarded blanklines metric in favor of "total lines" metric. Renamed…

26e2dba

… overall* metrics to total*

Fix

283e0ea

Moved metrics into statistics

d2dd20f

Added language metric tooltip in result list

887c18e

Moved/renamed filters

48f9b8a

In CSV exports, collection types get serialized to stringified JSON

14cc547

Autowiring csvMapper inside MainConfig.java

8498b41

dependabot bot and others added 14 commits June 16, 2023 07:38

Updated README.md application parameters

5e9191f

Merge pull request #105 from seart-group/dependabot/docker/docker/dev…

2450bcc

…elop/nginx-1.25.1-alpine-slim

Fixing merge error

cf3a439

CodeQL now triggers only on specific file changes

295a19a

Updating development configuration to use unedited backup image

aa5d986

Our custom override will only be used in production

Merge branch 'develop' into dependencies/spring-boot-3

c7794b5

Fixing holdover violation

62c0587

Updating security config to remove deprecated API usage

a182633

Fixing holdover violation

0ef4901

Newer version for stale action

0b04671

Checkstyle now also runs on Java file pushes on master and develop

3391bf2

Added Spring Boot Admin client settings

1a5b354

Added temporary logfile for actuator

ef0e20d

Will have the same contents as the console output. Not persisted between runs.

dabico mentioned this pull request Jun 20, 2023

Bump springframework.version from 2.7.10 to 3.0.4 #106

Closed

dabico added 6 commits June 20, 2023 15:11

Added checkstyle suppression filters

a99afee

Fixed text block formatting to conform to checkstyle

51420a7

Revert "Checkstyle now also runs on Java file pushes on master and …

3afdf77

…`develop`" This reverts commit 3391bf2.

Revert "CodeQL now triggers only on specific file changes"

fee3df0

This reverts commit 295a19a.

Merge branch 'develop' into dependencies/spring-boot-3

1cba3cd

Revert "Added checkstyle suppression filters"

ce79462

This reverts commit a99afee.

dabico force-pushed the develop branch 2 times, most recently from 05cb2e1 to 213b0d3 Compare June 21, 2023 08:16

Merge remote-tracking branch 'origin' into dependencies/spring-boot-3

afbecd6

dabico closed this Jun 21, 2023

dabico deleted the dependencies/spring-boot-3 branch June 21, 2023 08:32

dabico removed a link to an issue Jun 21, 2023

Migration to Spring Boot 3.1 and Java 17 #93

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java and Spring Version Migration #101

Java and Spring Version Migration #101

dabico commented Jun 14, 2023 •

edited

Loading

dabico commented Jun 20, 2023

dabico commented Jun 20, 2023

dabico commented Jun 22, 2023

Java and Spring Version Migration #101

Java and Spring Version Migration #101

Conversation

dabico commented Jun 14, 2023 • edited Loading

dabico commented Jun 20, 2023

dabico commented Jun 20, 2023

dabico commented Jun 22, 2023

dabico commented Jun 14, 2023 •

edited

Loading