Add Parser logging
#130
Merged
Add Parser logging
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `jclass` global references will be `NULL` if the dependency classes are not present. This makes them safe to load globally. Although loading `Logger` is a no-brainer, the reason we also need a `MarkerFactory` is because we want to distinguish the `TSLogType` values. Each value, `TSLogTypeLex` and `TSLogTypeParse` will have their respective markers.
The function signature aligns with what is required by `TSLogger.log`. It first checks if the `payload` is defined, which in our case is an instance of a `Logger` class. We then obtain the current JVM environment while attaching the current thread if necessary. We then construct an instance of `Marker` through the `MarkerFactory#getMarker`, its value based on the `TSLogType`. Finally, we call the `Logger#debug` method, passing the constructed `Marker` and a `String` from the character pointer. Although I'm quite happy with this implementation, we do restrict all logging to the `DEBUG` level.
This introduces two new native instance methods: - `Parser#getLogger` - `Parser#setLogger`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new instance methods to
Parser:Parser#getLoggerParser#setLoggerIt relies on the SLF4J logging facade to forward the information from
tree-sitterto aLoggerinstance. While writing logs to theDEBUGlevel, it will also include the appropriate log event type in the form of aMarker.