Add precise start and end offset byte values for Pattern
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were already extracting this information when building out `Query` instances, but for some reason, we did not include it in the `Pattern` objects that we constructed. This is no longer the case, and the same objects now clearly state the starting offset with respect to the `Query` they reside in.
It's not possible to set the field value because we copy all pattern characters (extra trailing whitespaces included) into the `Pattern` that we are constructing. To get around this, we can simply `trim` the value passed from the JNI when constructing the object. Then we can use the total string length of the value to calculate the end offset.
This still allows for a great deal of flexibility on the user end while still normalizing the resulting query `Pattern` values in a consistent (minimal, but legible) format.
Add new parametrized test, and extend `BaseTest` directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to determine the exact location of a
Patternwithin aQuery. For this to work properly, all user-submitted queries have to be normalized to a minimal, but human-readable format.