Adding a lot of new language bindings #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: I had to change build.py to make this work. For some reason, the owner of that repo makes a distinction between regular and "inline" markdown. I guess the latest version is ok? Either way we can revert to the old one if it ends up being unusable. Shame that this has to "ruin" the homogeneity of the build process.
Note: I had to change build.py to make this work. Again, the source is kept in a "non-standard" directory structure. But given that many projects seems to be doing this, I don't think that handling the special cases is an eyesore anymore.
Turns out they don't tag, and we have to track this one by revisions.
A null value would be returned if an extension was not present in the lookup map, violating the imposed contract.
Only edge cases returned immutable lists. The cases that returned values from the reverse lookup map were actually mutable, which may hinder the method's overall usability.
These two static `Parser` methods will be used to enforce language versioning. As of right now they are not used in the rest of the code. I think I will update the `LanguageTest` later to use these in checks.
We now also store the: - version - number of fields - number of symbols
A lot of things are not properly implemented, particularly pertaining to the versioning. Not sure if it's a good idea to offer support for it.
I have no idea how this happened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from supporting almost 50 languages in total, we also added the following features:
Languageenums through extensionsSymbolclassNodeis associated with aSymbolLanguagehas a collection ofSymbolinstancesParserLanguagevalidation now also checks the ABI versionsIn terms of removals, the deprecated
Parsermethods were removed.