-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Query
and QueryMatch
#37
Commits on Sep 28, 2023
-
Pattern string used to construct a
Query
is split into substringsWe essentially invoke the tree-sitter API at `build()` time to determine the starting offsets for each pattern of the full pattern string.
Configuration menu - View commit details
-
Copy full SHA for 458a0d4 - Browse repository at this point
Copy the full SHA 458a0d4View commit details -
Restoring the removed
getPattern
methodThe change of field signature caused this. We want to retain this method for backwards-compatibility purposes.
Configuration menu - View commit details
-
Copy full SHA for 2151802 - Browse repository at this point
Copy the full SHA 2151802View commit details -
Configuration menu - View commit details
-
Copy full SHA for 131a10a - Browse repository at this point
Copy the full SHA 131a10aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1de5850 - Browse repository at this point
Copy the full SHA 1de5850View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e514e8 - Browse repository at this point
Copy the full SHA 2e514e8View commit details -
Creating a dedicated object for
Query
patterns:Pattern
May see revisions in terms of structure
Configuration menu - View commit details
-
Copy full SHA for 2741761 - Browse repository at this point
Copy the full SHA 2741761View commit details
Commits on Sep 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3f11c7d - Browse repository at this point
Copy the full SHA 3f11c7dView commit details -
Creating a dedicated object for
Query
captures:Capture
May see revisions in terms of structure
Configuration menu - View commit details
-
Copy full SHA for 2f04711 - Browse repository at this point
Copy the full SHA 2f04711View commit details -
Renaming
id
toindex
inCapture
andPattern
The first term is treated equivalently to the second by the tree-sitter library, but I feel like the new name makes more sense to the programmer as it reflects its true purpose
Configuration menu - View commit details
-
Copy full SHA for 1a448e3 - Browse repository at this point
Copy the full SHA 1a448e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 641f9f6 - Browse repository at this point
Copy the full SHA 641f9f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75ba266 - Browse repository at this point
Copy the full SHA 75ba266View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5417f5c - Browse repository at this point
Copy the full SHA 5417f5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fac392 - Browse repository at this point
Copy the full SHA 2fac392View commit details -
Configuration menu - View commit details
-
Copy full SHA for 391a10e - Browse repository at this point
Copy the full SHA 391a10eView commit details -
We no longer load the "captures" field from
QueryMatch
The type of said field will soon be changed, so this will quickly become an invalid reference. But apart from that, we don't use it anywhere, so it's not a loss at all.
Configuration menu - View commit details
-
Copy full SHA for 9247644 - Browse repository at this point
Copy the full SHA 9247644View commit details -
The
Map
andEntry
inner class are loaded at JNI levelI fell that we can use some sort of `Capture` -> `Node` map to replace the now-confusingly-named `QueryCapture` class. However, since one `Capture` instance will be able to map to multiple nodes, we will need to introduce some kind of multi-value variant of `Map` to store captures
Configuration menu - View commit details
-
Copy full SHA for b30830b - Browse repository at this point
Copy the full SHA b30830bView commit details -
Configuration menu - View commit details
-
Copy full SHA for eba044e - Browse repository at this point
Copy the full SHA eba044eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ea5c7f - Browse repository at this point
Copy the full SHA 4ea5c7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7a2ccf - Browse repository at this point
Copy the full SHA e7a2ccfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8670d9 - Browse repository at this point
Copy the full SHA a8670d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f6aea0 - Browse repository at this point
Copy the full SHA 1f6aea0View commit details
Commits on Sep 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 80cac17 - Browse repository at this point
Copy the full SHA 80cac17View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdf8dae - Browse repository at this point
Copy the full SHA fdf8daeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 487aca1 - Browse repository at this point
Copy the full SHA 487aca1View commit details -
Overriding
equals
andhashCode
inCapture
andPattern
Documentation is also updated to reflect this change
Configuration menu - View commit details
-
Copy full SHA for e0e947a - Browse repository at this point
Copy the full SHA e0e947aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1413167 - Browse repository at this point
Copy the full SHA 1413167View commit details -
Configuration menu - View commit details
-
Copy full SHA for d77264b - Browse repository at this point
Copy the full SHA d77264bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b545411 - Browse repository at this point
Copy the full SHA b545411View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16017ca - Browse repository at this point
Copy the full SHA 16017caView commit details -
Separating another test method
The superclass will probably be renamed
Configuration menu - View commit details
-
Copy full SHA for 2231037 - Browse repository at this point
Copy the full SHA 2231037View commit details -
Configuration menu - View commit details
-
Copy full SHA for 790c93c - Browse repository at this point
Copy the full SHA 790c93cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09a93ea - Browse repository at this point
Copy the full SHA 09a93eaView commit details -
Merge branches 'enhancement/query' and 'enhancement/query' of https:/…
…/github.com/seart-group/java-tree-sitter into enhancement/query
Configuration menu - View commit details
-
Copy full SHA for b4be833 - Browse repository at this point
Copy the full SHA b4be833View commit details