Improvements to QueryCursor
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subsequent calls to `execute` will now reset the cursor to its initial state. The significance of this change might seem minute at first, but will become apparent when we introduce the ability to limit searches to a range of bytes or row/column coordinates.
These two new overloaded variants allow us to limit queries to a narrower byte and position range. This could yield increased performance when querying, as larger files can be broken up into several smaller portions which are queried individually.
This had to be done to preserve the current functionality of the `iterator()` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains two major changes to
executeAPIs ofQueryCursor:execute, as opposed to doing nothing;setRangemethods were added to support narrower searches (bybyteandPointrange).