Sample API update #329
Merged
Sample API update #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davereinhart
force-pushed
the
sample-api-update
branch
from
0422437
to
51a4b85
Compare
bencap
approved these changes
Aug 30, 2023
My thought was that if the only thing changing is the provenance, then the record's actual data is not changing, so the update isn't needed and the new provenance isn't really relevant. |
Allow `access_role` value to be set via warehouse/sample POST endpoint. This column is used in the table's row-level security policy to restrict access to specific database roles as needed.
When detecting data changes in sample upsert function, timestamp changes in the `_provenance` were causing otherwise unchanged records to be updated. Removing this value for comparison purposes in a copy of the dict, and retaining the original for insert and update.
davereinhart
force-pushed
the
sample-api-update
branch
from
7bb6147
to
c2126ad
Compare
|
Ah ok, that seems fair wrt provenance- Thanks! |
|
Deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to warehouse/sample POST endpoint to allow
access_rolevalue to be passed. A database constraint will ensure this value is set correctly based on thesample_originwhich can be used to identify data from a project that should have restricted access.