Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helm YAML from seaweedfs repo #112

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

Jackbennett
Copy link
Contributor

@Jackbennett Jackbennett commented Mar 14, 2023

Publish the helm chart via github pages, with a simple CI lint of the chart on PR.

Thanks to @washcycle as I just lifted their seaweedfs at seaweedfs/seaweedfs#4243

Updated the paths and tested on my fork so far as proving it works. You might want to update the Chart.yaml appVersion: latest to a number, not sure how you want to handle this.

Required setup by maintainer for gh-pages branch to exist before the release workflow can complete;

git switch --orphan gh-pages
git commit --allow-empty -m "Initial Commit for Helm Releases"
git push origin gh-pages

@chrislusf chrislusf merged commit 3596a9a into seaweedfs:master Mar 14, 2023
@chrislusf
Copy link
Contributor

Merged and set up gh-pages branch.

Let me know how to test it is working.

@washcycle
Copy link
Contributor

@Jackbennett thanks this was on my long list of to-dos, glad someone jumped in. Open source working as intended.
Cheers!

@washcycle
Copy link
Contributor

@chrislusf can add this helm chart to the seaweedfs artifact hub after this.

@Jackbennett
Copy link
Contributor Author

Merged and set up gh-pages branch.

Let me know how to test it is working.

With gh-pages existing you should just have to make a tag. You'll have to make a new version I think.

There's quite a few changes between this and 1.1.2 in master so moving the tag and re-pushing 1.1.2 now that this workflow exists.

If you want to try republishing 1.1.2 before minting a new version then I think you make a "release" branch from 1.1.2, cherry-pick these commit and move the 1.1.2 tag.

Once the workflow completes you can check https://seaweedfs.github.io/seaweedfs-csi-driver/helm/index.yaml should render some yaml pointing to the tar.gz of the chart which the helmcli with read with helm repo add etc.

@Jackbennett Jackbennett deleted the pr/helm_repo_ci_gh_pages branch November 14, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants