Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Base #1857

Merged
merged 45 commits into from
Dec 20, 2024
Merged

Field Base #1857

merged 45 commits into from
Dec 20, 2024

Conversation

astrit
Copy link
Member

@astrit astrit commented Dec 3, 2024

The scope:


Atoms:

  • Field Atom
    • Floating Label ( Optional )
    • Floating Label Two Columns ( Account Selector )

API - #1861

  • Ensure consistent API for form controls.
    • Validation and feedback
    • Events
    • All controls should implement ElementInternals as formAssociated components, and behave like native controls to the extent possible.
  • Verify usability in Angular
  • Verify usability in React

Tests

  • API tests
  • Accessibility tests
  • Interaction tests

Select ( New Component )

This pull request adds a new select component to the libs/core/src/components directory. The changes include new files for the component's implementation, styles, tests, and Storybook stories.

@green-design-system-bot
Copy link
Contributor

green-design-system-bot bot commented Dec 3, 2024

🦋 Changeset status

None or empty changeset found. This PR will not result any new releases.

If you believe this is incorrect, please add a changeset by running npx changeset, and then commiting the resulting changeset file.

You can also explicitly add an empty changeset by running:
npx changeset add --empty

@green-design-system-bot
Copy link
Contributor

green-design-system-bot bot commented Dec 3, 2024

👋 Thanks for creating a pull request!

🚀 Checkout the storybooks we've created for it:

@splashdust splashdust marked this pull request as draft December 5, 2024 12:58
@astrit astrit marked this pull request as ready for review December 11, 2024 15:52
@astrit astrit changed the title Consolidate form components, controls and new component gds-select Field Base Dec 16, 2024
@astrit astrit requested a review from splashdust December 16, 2024 10:21
@astrit astrit self-assigned this Dec 16, 2024
@splashdust splashdust merged commit 83bcedb into main Dec 20, 2024
5 checks passed
@splashdust splashdust deleted the input/finalize branch December 20, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants